Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change DefaultGenerator members visibility - ref #7722 #9136

Merged
merged 3 commits into from
Jan 30, 2019
Merged

change DefaultGenerator members visibility - ref #7722 #9136

merged 3 commits into from
Jan 30, 2019

Conversation

frantuma
Copy link
Member

@frantuma frantuma commented Jan 30, 2019 •
edited
Loading

refs #7722; includes and replaces #8097 (rebased)

  • Changed most private fields and methods on DefaultGenerator to protected.
  • Changed names of boolean fields so methods and field names weren't different only by capitalization

@frantuma frantuma force-pushed the feature/7722-liberate-defaultgenerator branch 2 times, most recently from 72108f3 to aa60036 Compare January 30, 2019 16:31
@frantuma frantuma force-pushed the feature/7722-liberate-defaultgenerator branch from aa60036 to 82176f1 Compare January 30, 2019 17:14
@frantuma frantuma changed the title change DefaultGenerator members visibility - ref #1004 change DefaultGenerator members visibility - ref #8097 Jan 30, 2019
@frantuma frantuma changed the title change DefaultGenerator members visibility - ref #8097 change DefaultGenerator members visibility - ref #7722 Jan 30, 2019
@frantuma frantuma merged commit 377174f into master Jan 30, 2019
This was referenced Jan 30, 2019
Closed
Closed
@frantuma frantuma deleted the feature/7722-liberate-defaultgenerator branch January 30, 2019 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@frantuma @DarkWingDuckWing