Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the polymorphic issue #8900

Merged
merged 7 commits into from
Jan 12, 2019
Merged

fix the polymorphic issue #8900

merged 7 commits into from
Jan 12, 2019

Conversation

alexz0000
Copy link

@alexz0000 alexz0000 commented Nov 9, 2018

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: 3.0.0 branch for changes related to OpenAPI spec 3.0. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

(details of the change, additional tests that have been done, reference to the issue for tracking, etc)

@alexz0000
Copy link
Author

alexz0000 commented Nov 20, 2018

@wing328 team, could you help to review the issue and the PR? Do you think it's OK to merge the code? Thanks

@JeremyTangCD
Copy link

For the failure of the "continuous-integration/appveyor/pr" above, it has been improved in 14ffc12 at Nov. 12, 2018
This branch is just forked at Nov. 9, 2018.
So it is not caused by the committing codes, we could ignore it.

@wing328
Copy link
Contributor

wing328 commented Nov 24, 2018

@AlexInGitHub Thanks for tagging me but I'm no longer involved in this project. I hope others will be able to help you out. Good luck.

@JeremyTangCD
Copy link

Hi @kenjones-cisco , could you help to review this PR? Thanks a lot.

@kenjones-cisco
Copy link
Contributor

LGTM!
Thanks @AlexInGitHub

@JeremyTangCD
Copy link

@kenjones-cisco Thank you for reviewing, do you know who can help to merge this PR?

@alexz0000
Copy link
Author

@kenjones-cisco Could you help to merge the code? since we are waiting for using the feature, thank you very much.

@kenjones-cisco
Copy link
Contributor

Sorry, I'm not able to help with merge.

@alexz0000
Copy link
Author

@kenjones-cisco Do you know who can merge the code?

@woz5999
Copy link
Contributor

woz5999 commented Jan 2, 2019

@webron @HugoMario Can someone please help figure out who is able to review and merge this mix?

@HugoMario
Copy link
Contributor

sorry for delay guys, and thanks a lot @AlexInGitHub for PR!!!!

@HugoMario HugoMario merged commit 42462db into swagger-api:master Jan 12, 2019
@motherclangercsinternal

How is it looking on fixing the failing Petstore integration tests, please?
I have my own PR that I would like to test.

@alexz0000
Copy link
Author

@motherclangercsinternal I remembered there should be some error messages on your PR's page

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants