Fix getHasQueryParams to take authMethods into account #8292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getHasQueryParams only checks if queryParams is not empty, but query params could also be defined by authMethods. Fixes swagger-api#7303
|
thanks a lot @AsamK |
2 tasks
bezineb5
added a commit
to bezineb5/swagger-codegen
that referenced
this pull request
May 19, 2020
Fixes swagger-api#7303 for V3 This is the V3 port of the fix swagger-api#8292
4 tasks
bezineb5
added a commit
to bezineb5/swagger-codegen
that referenced
this pull request
May 19, 2020
Fixes swagger-api#7303 for V3 This is the V3 port of the fix swagger-api#8292
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.shand./bin/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\.3.0.0branch for changes related to OpenAPI spec 3.0. Default:master.Description of the PR
getHasQueryParams only checks if queryParams is not empty, but
query params could also be defined by authMethods.
Fixes #7303
I'm not sure about the petstore script, do I have to run all of them and commit the changes?