[PHP] Fix code example from README. Variable name was missing when using Basic auth. #7777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have no ideas how (and why) fix in the README template broke 12 tests. |
|
Thanks for your contribution!
I think this PR has nothing to do with it as other build is failing with same error as well. PHPUnit seems finished successfully, so it looks good to me ✨ |
ackintosh
approved these changes
Mar 7, 2018
|
@alexions thanks for the PR. The failing tests have nothing to do with your PR. Likely something change in the build image (Travis) and we'll need to investigate further. @ackintosh thanks for reviewing the change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix code example from README. Variable name was missing when using Basic auth.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.shand./bin/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\.3.0.0branch for changes related to OpenAPI spec 3.0. Default:master.@jebentier (2017/07) @dkarlovi (2017/07) @mandrean (2017/08) @jfastnacht (2017/09) @ackintosh (2017/09)
Description of the PR
In the previous change (link in the description) $config variable was accidentally removed. So the generated README file had incorrect code example when using basic auth.
9ca9887#diff-48c9b5ad08e2cc9e563b3ac9da839117
I have restored variable name and checked the code example after generation.