[TypeScript] Take the modelPropertyNaming property into account again #7202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@JFCote did you verify that it fixes #7201? |
|
@TiFu Sorry, I can't compile Java right now, but the changes are looking good for me. |
|
@TiFu I did not have time to do the validation. I just wanted to provide a quick fix but I'm pretty confident that it should work. There was no sample using this parameter and nothing has changed when running the samples so at least, it didn't break anything. If I have time later this week, I will test it. Otherwise, if someone here with the right setup can test it, that would be nice :) Thanks |
|
Tested with a build against PR 7202 and it does honor the modelPropertyNaming option again. |
slarti-b
added a commit
to slarti-b/swagger-codegen
that referenced
this pull request
Dec 26, 2017
* master: move bvwells to go tech comm update current stable version in readme skip push snapshot to avoid error comment out checkstyle in circleci pom.xml comment out check style plugin Revert "update version to 2.4.0-SNAPSHOT" update ci config to install codegen locally update doc to 2.3.0 update version to 2.4.0-SNAPSHOT update version to 2.3.0 fix net35 with JsonSubTypes (swagger-api#7043) [Javascript] Set ES5 as default (swagger-api#7239) swagger-api#7201: Take the modelPropertyNaming property into account again (swagger-api#7202) add trenneman as elm creator add bvwells to go technical committee Video "Building an API with Swagger" (swagger-api#7237) [Akka-Scala] This is a fix to a bug introduced by this PR swagger-api#7172 (swagger-api#7228) Add Elm language - BETA (swagger-api#6947) bump stack resolver to lts-10.0 (swagger-api#7221)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.shand./bin/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\.3.0.0branch for changes related to OpenAPI spec 3.0. Default:master.@TiFu (2017/07) @taxpon (2017/07) @sebastianhaas (2017/07) @kenisteward (2017/07) @Vrolijkx (2017/09)
Description of the PR
Fix for #7201.