[Eiffel] Add Eiffel API client generator #6036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TODO API and Domain model
Added mustaches templates for models and apis. The last one still under development.
Added client request template.
Added test case generation, clean code.
Updated readme file
Updated API client to support by default a basic json (de)serializer and let the user customize then if needed.
Updated templates to follow Eiffel style. Improved feature descriptions.
Removed unused code.
Added Eiffel sample in samples/client/petstore/eiffel.
Added TestCases for EfiffelClientOption and ModelTest cases. Updated sample code to use the lastest changes.
wing328
reviewed
Jul 13, 2017
| @@ -56,8 +56,7 @@ public GoClientCodegen() { | |||
| "case", "defer", "go", "map", "struct", | |||
| "chan", "else", "goto", "package", "switch", | |||
| "const", "fallthrough", "if", "range", "type", | |||
| "continue", "for", "import", "return", "var", "error", "ApiResponse", | |||
| "nil") | |||
| "continue", "for", "import", "return", "var", "error", "ApiResponse") | |||
|
@jvelilla overall it looks good. I'll create a separate ticket to track several enhancements that I can think of. |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.shand./bin/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates)2.3.0branch for breaking (non-backward compatible) changes.Description of the PR
Initial code of a functional Eiffel API client code generator, which has been tested with Petstore.
There are still some features pending to be added, for example, improve unit tests and more.