Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option for resolveFully #10200

Merged
merged 3 commits into from
May 8, 2020
Merged

Add option for resolveFully #10200

merged 3 commits into from
May 8, 2020

Conversation

jweisman
Copy link

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: 3.0.0 branch for changes related to OpenAPI spec 3.0. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

Add option to set ParseOptions.setResolveFully to fully walk the reference tree for responseBodies and schemas.

@jweisman jweisman mentioned this pull request Apr 23, 2020
3 tasks
@daemonfire300
Copy link

@jweisman I could test this against my locally present collection of yaml's to check whether this is working, but need to figure out the command parameters again, since it has been quite some time since I had a look at this.

@jweisman
Copy link
Author

jweisman commented May 4, 2020

Hi @daemonfire300 - I used the following to test:

java -jar modules/swagger-codegen-cli/target/swagger-codegen-cli.jar generate \
-i https://developers.exlibrisgroup.com/wp-content/uploads/alma/openapi/users.json \
-l java \
-o ~/java-client \
--resolve-fully

@HugoMario HugoMario self-assigned this May 8, 2020
@HugoMario
Copy link
Contributor

Hi @jweisman , thanks for your PR's and sorry for delay on previous one. Please, ping me next time you want a PR be merged. I really like the idea of adding the resolve-fully feature as an option, in that case we dont force to anybody to use it if they dont want.

@HugoMario
Copy link
Contributor

please build

@HugoMario
Copy link
Contributor

thanks again @jweisman !!!

@HugoMario HugoMario merged commit 46f199a into swagger-api:3.0.0 May 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants