Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Maven repo missing 3.x.x versions #10039

Merged
merged 2 commits into from
Feb 20, 2020
Merged

[docs] Maven repo missing 3.x.x versions #10039

merged 2 commits into from
Feb 20, 2020

Conversation

josh31416
Copy link
Contributor

Download url for current stable of the 3.x.x branch was missing in the prerequisites section of the README.
Without this specification the user may not realize their is a newer version available, specially those who don't want to clone the project and build it.

Resolves: #9475
See also: #9588

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: 3.0.0 branch for changes related to OpenAPI spec 3.0. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

Download url for current stable of the 3.x.x branch was missing in the prerequisites section of the README.
Added download link for 3.0.16 current stable of maven repo
Without this specification the user may not realize their is a newer version available, specially those who don't want to clone the project and build it.

Download url for current stable of the 3.x.x branch was missing in the prerequisites section of the README.
Without this specification the user may not realize their is a newer version available, specially those who don't want to clone the project and build it.

Resolves: #9475
See also: #9588
README.md Outdated
wget https://repo1.maven.org/maven2/io/swagger/swagger-codegen-cli/2.4.12/swagger-codegen-cli-2.4.12.jar -O swagger-codegen-cli.jar

# Download current stable 3.x.x branch
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be helpful to point out that 3.x.x is meant for OpenAPI 3.0 while 2.x.x is meant for Swagger (not sure if 3.x.x supports both Swagger and OpenAPI 3.0, though).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. Great tip. Thanks Igor.

Specified that 2.x.x branch is for Swagger and OpenAPI version 2, and that branch 3.x.x is for OpenAPI version 3.

Resolves: #9475
See also: #9588
@frantuma frantuma merged commit fc902a6 into swagger-api:master Feb 20, 2020
@frantuma
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3.0.x versions missing in maven
3 participants