Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the go generation scripts and docker runner script #10016

Merged
merged 3 commits into from
Feb 11, 2020

Conversation

szank
Copy link

@szank szank commented Jan 31, 2020

fix #10015

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: 3.0.0 branch for changes related to OpenAPI spec 3.0. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Fixes the issues with ./run-in-docker.sh, ./bin/go-petstore.shand./bin/go-petstore-server.sh` scriptss

@henrebotha
Copy link

@frantuma @HugoMario

@HugoMario HugoMario merged commit 4e0e4f9 into swagger-api:3.0.0 Feb 11, 2020
@HugoMario
Copy link
Contributor

thanks @szank @henrebotha !!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants