Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#780 python flask dependencies #782

Merged

Conversation

jstockdi-marstone
Copy link
Contributor

Addresses Issue #780

Changes include:

  • Incrementing connexion
  • Incrementing flask_test
  • Adding tox to test-requirements.txt

Copy link

@ulidtko ulidtko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✔️

Please merge.

@jstockdi-marstone
Copy link
Contributor Author

@ulidtko - Do you have write access to merge? Maybe @HugoMario ? Let me know how I can push this over the line...

@ulidtko
Copy link

ulidtko commented Oct 30, 2020

No, I'm not a committer here.

@HugoMario please merge, this fixes spec-first/connexion#1149 which is impacting a lot of people. connexion == 2.2.0 was released almost 2 years ago; as you can see in the issue, updating to connexion == 2.6.0 in the swagger-codegen-generated Python/Flask project did resolve the issue for pretty much everyone there.

The other change proposed in this PR addresses "broken out of the box" unit-testing in the generated skeleton.

Having this PR merged (& released) will fix the "getting started with swagger-codegen" experience for Python users.

@HugoMario
Copy link
Contributor

thanks a lot for this PR!!!

@HugoMario HugoMario merged commit 45812fd into swagger-api:master Oct 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants