Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Micronaut] Change class to interface in api.mustache file and add unit tests #727

Merged
merged 1 commit into from
Jul 12, 2020
Merged

[Micronaut] Change class to interface in api.mustache file and add unit tests #727

merged 1 commit into from
Jul 12, 2020

Conversation

shourien
Copy link
Contributor

Changed class to interface.
Added Unit tests.
Removed new line character in mustache files to generate readable API files.
Fixed Test file to use a generic OS independent lineSeperator() function.

@shourien
Copy link
Contributor Author

@HugoMario please find a draft pull request. I will move this to Ready for review in some time today.

@shourien shourien marked this pull request as ready for review July 12, 2020 06:00
@HugoMario HugoMario merged commit e64828e into swagger-api:master Jul 12, 2020
@HugoMario
Copy link
Contributor

thanks a lot @shourien !!

@shourien
Copy link
Contributor Author

@HugoMario Thanks for merging this change. In addition while working with the code generator for micronaut there were couple of additional issues with regards to bean validation which I found. I have documented all the issues in #728

I have also raised a pull request to fix all those issues #729

hope you can review them, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants