Fix current membership is inactive future membership #3777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…leted This means that sometimes, memberships are slightly longer than a year, now officially making sjaars members from intro up to sept 1, instead of abusing the lack of checks on membership.since when checking for an active membership.
T8902
reviewed
Aug 16, 2024
|
when trying to pay for a registration using cash |
correction, any payment |
Looks like you're running on a database from your study-long branch |
Yes I am just stupid |
T8902
approved these changes
Aug 16, 2024
DeD1rk
added a commit
that referenced
this pull request
Aug 17, 2024
* Refactor uses of current_membership that only need has_active_membership * Make current_membership actually return the current and not latest membership * Fix members app test discovery * Add tests for current- and latest_membership properties * Make memberships start on the day the registration or renewal is completed This means that sometimes, memberships are slightly longer than a year, now officially making sjaars members from intro up to sept 1, instead of abusing the lack of checks on membership.since when checking for an active membership. * Fix tests * Add coverage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3776.
Summary
Before this, two things were done in an ugly/inaccurate way:
Member.current_membershipreturned the latest membership, even if it hadn't begun yet.But before 0f6488a, we did not check for the
membership.sincedate when checking if a membership is active. This meant that the above 2 things together gave the expected behaviour. So adding that check broke the expected but hacky behaviour.In this PR, I got rid of both weird things. Memberships normally start at the date they're completed (typically i.e. paid). For memberships completed in august, that means that the last few days/weeks of august are given 'for free' as they were before, but just also stored that way. And the
current_membershipproperty and friends now do what one would expect: return only current memberships.How to test