Skip to content

Commit

Permalink
fix: Sonos2mqtt images upgraded to node 20
Browse files Browse the repository at this point in the history
  • Loading branch information
svrooij committed Mar 30, 2024
1 parent 42b3ff7 commit 01fbef3
Show file tree
Hide file tree
Showing 3 changed files with 16 additions and 16 deletions.
26 changes: 13 additions & 13 deletions .github/workflows/build-and-release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,10 +31,10 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
node: [16, 18]
node: [18, 20]
steps:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version: ${{ matrix.node }}
- name: Install depencencies
Expand All @@ -56,16 +56,16 @@ jobs:
released: ${{ steps.semantic.outputs.new_release_published }}
version: ${{ steps.semantic.outputs.new_release_version }}
steps:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version: 16
node-version: 20
- name: Install depencencies
run: npm ci
- name: Build library
run: npm run build
- name: Semantic Release
uses: cycjimmy/semantic-release-action@v3
uses: cycjimmy/semantic-release-action@v4
id: semantic
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
Expand All @@ -74,7 +74,7 @@ jobs:
if: steps.semantic.outputs.new_release_published == 'true'
uses: actions/setup-node@v3
with:
node-version: 16
node-version: 20
registry-url: 'https://npm.pkg.github.com'
scope: 'svrooij'
- name: Publish To GitHub Package Registry
Expand All @@ -92,31 +92,31 @@ jobs:
needs: [npm-release]
if: needs.npm-release.outputs.released == 'true'
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4

-
name: Set up QEMU (multi platform)
uses: docker/setup-qemu-action@v2
uses: docker/setup-qemu-action@v3
with:
platforms: all

-
name: Set up Docker Buildx
id: buildx
uses: docker/setup-buildx-action@v2
uses: docker/setup-buildx-action@v3
with:
version: latest

-
name: Login to DockerHub
uses: docker/login-action@v2
uses: docker/login-action@v3
with:
username: ${{ secrets.DOCKER_USERNAME }}
password: ${{ secrets.DOCKER_PASSWORD }}

-
name: Login to GitHub Container Registry
uses: docker/login-action@v2
uses: docker/login-action@v3
with:
registry: ghcr.io
username: ${{ github.actor }}
Expand Down
4 changes: 2 additions & 2 deletions Dockerfile
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
FROM node:16-alpine3.15 as build
FROM node:lts-alpine as build
WORKDIR /usr/src/app
COPY package*.json tsconfig.json ./
RUN npm ci
COPY ./src ./src
RUN npm run build

FROM node:16-alpine3.15 as prod
FROM node:lts-alpine as prod
ARG BUILD_DATE=unknown
ARG BUILD_VERSION=0.0.0-development
ARG VCS_REF=not-set
Expand Down
2 changes: 1 addition & 1 deletion Dockerfile.npm
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
# COPY ./src ./src
# RUN npm run build

FROM node:16-alpine3.15 as prod
FROM node:lts-alpine as prod
ENV SONOS2MQTT_RUNNING_IN_CONTAINER=true
WORKDIR /usr/src/app

Expand Down

0 comments on commit 01fbef3

Please sign in to comment.