fix: add Fragment declaration in svg.js.d.ts

[we125182]

this pr is to fix issue #1307 .

[Fuzzyma]

Would it make sense to let fragment simply extend from Container to avoid duplication?

[we125182]

Actually, I thought in this way. After read source code, find that Container extends Element, but Fragment extends Dom. if Fragment extends Container, it'll has Element methods, but Fragment doesn't have methods of Element

[Fuzzyma]

mh, maybe you can add an interface "Containerable" which has all the methods and both fragment and container extend from it

[we125182]

I tried the Interface way. But implements Containerable Interface, you need define same medthods too. in this way, need define same method three times(Containerable, Fragment, Container). Certanlly use interface can ensure Container and 'Frament` has same Constuct Element methods.

try on TS PLAYGROUND

[Fuzzyma]

Alright, last straw: use a class instead of an interface as intermediate layer. But don't export that class since it doesn't exist

[we125182]

I use the dynamic extends to avoid dupliacted declarations. But the temp varibles(ContainableDom, ContainableElement) always export. which means user can import them, actually they didn't exist. I add comment to explain. Maybe there has a good way.

[Fuzzyma]

I don't think anyone will ever import them.
If everything else works like intended I would consider this a good solution :).
Does everything work?

[we125182]

Yes, I linked the changed package in a project. Fragment has methods of Containable and Dom. Container keep same behavior.

[Fuzzyma]

Awesome. Thank you!

[we125182]

Glad to help.