Refactoring of the Source Code Generator #1141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Moved the Svg_Model.cs file as SvgModel.cs into the main source. - Restore the standard naming of the generated code files with "*.g.cs" suffix. - Set the output directory of the generated codes to "Generated". - Added the Generated directory to the main source codes. - Moved the Svg.Custom project to Tests directory.
- NuGet/setup-nuget@v1 to NuGet/setup-nuget@v2 - Needed to eliminate the warning: Node.js 16 actions are deprecated.
Removed the comment out portions.
mrbean-bremen
approved these changes
Feb 3, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Feb 3, 2024
…rators README.md Samples Source Tests doc docfx.json index.md license.txt Refactoring of the Source Code Generator - Moved the Svg_Model.cs file as SvgModel.cs into the main source. - Restore the standard naming of the generated code files with "*.g.cs" suffix. - Set the output directory of the generated codes to "Generated". - Added the Generated directory to the main source codes. - Moved the Svg.Custom project to Tests directory. CONTRIBUTING.md Generators README.md Samples Source Tests doc docfx.json index.md license.txt Update runtests.yml - NuGet/setup-nuget@v1 to NuGet/setup-nuget@v2 - Needed to eliminate the warning: Node.js 16 actions are deprecated. CONTRIBUTING.md Generators README.md Samples Source Tests doc docfx.json index.md license.txt Update AvailableElementsGenerator.cs Removed the comment out portions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Svg_Model.csfile asSvgModel.csinto the main source.*.g.cssuffix.Generated.Show All Files.Svg.Customproject to theTestsdirectory.Type of change
SvgModel.cs, originally part of the code generator, includes attribute classes.docfxfor documentation.docfxissue with attributes: [Bug] Using Roslyn Source Generators with attribute class fails dotnet/docfx#9619docfxcurrently provides no solution other than a warning.How Has This Been Tested?