Main Project Cleanup #1123

paulushub · 2024-01-14T10:51:10Z

Description

Clean up of the main source code project
Removed irrelevant files
Added support for .NET 4.7, .NET 4.8
Removed preprocessor to enable events registration for all
Updates to the SvgOptions class to support key-value properties. Will use it to resolve issue raised in * Improve picture clarity #987
Split ItemGroup for references into supported Frameworks, so dependent package versions can be separately updated.
Resolved main concern in Added net6.0-windows to TFMs. #1019

Type of change

How Has This Been Tested?

SvgW3CTestRunner is tested for each supported platform
Svg.UnitTests tested on command line for each supported platform
Svg.Benchmarks tested on command line for each supported platform, warnings are as before will be addressed later.

- Clean up of the main source code project - Removed irrelevant files - Added support for .NET 4.7, .NET 4.8 - Removed preprocessor to enable events registration for all - Updates to the SvgOptions class to support property attributes

Samples/Entities/Entities.csproj

mrbean-bremen · 2024-01-14T11:08:40Z

Source/DataTypes/EnumConverters.cs

+    //            return false;
+    //        }
+    //    }
+    //}


Is this not needed bevause you just use Enum? In this case just remove it.
@H1Gdev may have a look as he introduced this.

Thanks, we wait for @H1Gdev.
The generic support for the parsing enum string was not available in 3.5, so that might be needed but no more.

@paulushub @mrbean-bremen

I agree with remove it.
It would be beneficial to be able to remove [CLSCompliant(false)].

@H1Gdev Thanks for the feedback. I will now remove the commented code.

mrbean-bremen · 2024-01-14T11:12:53Z

Source/Svg.csproj

+        <DefineConstants Condition="$(TargetFramework.StartsWith('net47'))">$(DefineConstants);DOTNET47;NETFULL</DefineConstants>
+        <DefineConstants Condition="$(TargetFramework.StartsWith('net48'))">$(DefineConstants);DOTNET48;NETFULL</DefineConstants>


Why are these needed?

Added support for .NET Framework 4.7 and 4.8, for project using them.
The constants are provided in case any platform specific coding is necessary. Currently, only NETFULL is used.

Ok, as long as there are no additional projects are build by default, it won't actually matter, so it is ok, I guess.

Tests/Svg.Benchmark/Svg.Benchmark.csproj

- Applying the default "Format Document" introduces the tabs!

paulushub · 2024-01-14T12:26:25Z

@mrbean-bremen Sorry for the crazy tabs, I have fixed it.
I only applied Edit -> Advanced -> Format Document, but unfortunately the tabify option is still on in my current machine.

mrbean-bremen

Looks good to me, but I would want to have @H1Gdev have another look.

paulushub · 2024-01-14T12:35:19Z

Looks good to me, but I would want to have @H1Gdev have another look.

Thanks, trying to add him to the reviewers, but the name is not showing up.

mrbean-bremen · 2024-01-14T12:39:51Z

Thanks, trying to add him to the reviewers, but the name is not showing up.

I also had tried to add him to the contributors. Anyway, he will get notifications from mentioning. And I think he is in a similar timezone as you, so it should be easier for you to communicate ;)

- Set the default mode to InterpolationMode.Default

paulushub · 2024-01-14T13:36:35Z

@mrbean-bremen Unfortunately, not all interpolation modes will allow the SVG-logo to pass the tests. So, I set the default as Default, let any user who wants to experiment with his/her desired mode of interpolation to use the SvgOptions.
Since this is not a W3C test file, I do not know how the reference PNG is created.

- Removed NuGet project files and folder - Removed non-existence folder: <Folder Include="Web\Resources\" />

H1Gdev · 2024-01-16T00:19:32Z

Source/Rendering/SvgRenderer.cs

@@ -135,7 +135,7 @@ private static Graphics CreateGraphics(Image image)
            g.CompositingQuality = CompositingQuality.HighQuality;
            g.TextRenderingHint = TextRenderingHint.AntiAlias;
            g.TextContrast = 1;
-            g.InterpolationMode = InterpolationMode.NearestNeighbor;


@paulushub

Do you need to change this setting ?
I recommend that you change this setting carefully, such as by creating another PR.

It was added by a PR we allowed to record the contribution and close the issue as we planned to improve the implementation.
However, as you can see it is causing the build to fail with a SVG-Logo.
So, I set it to Default to make all the tests pass as before.

H1Gdev · 2024-01-16T00:23:41Z

Source/SvgOptions.cs

 {
-    public SvgOptions()
+    public class SvgOptions : IDictionary<string, string>, ICloneable


I think it would be better to inherit Dictionary.

Just wanted it to be as dictionary, we might change the base (and internal) to anything later.

- Enums no longer needed.

paulushub · 2024-01-16T10:22:03Z

@mrbean-bremen @H1Gdev Sorry, if it is OK with you, I will merge this PR.

…ples Source Svg.Custom Tests doc docfx.json index.md license.txt Main Project Cleanup - Clean up of the main source code project - Removed irrelevant files - Added support for .NET 4.7, .NET 4.8 - Removed preprocessor to enable events registration for all - Updates to the SvgOptions class to support property attributes CONTRIBUTING.md Generators README.md Samples Source Svg.Custom Tests doc docfx.json index.md license.txt Untabify the project files - Applying the default "Format Document" introduces the tabs! CONTRIBUTING.md Generators README.md Samples Source Svg.Custom Tests doc docfx.json index.md license.txt Restore the default interpolation mode of the GDI+ rendererer - Set the default mode to InterpolationMode.Default CONTRIBUTING.md Generators README.md Samples Source Svg.Custom Tests doc docfx.json index.md license.txt Further clean up - Removed NuGet project files and folder - Removed non-existence folder: <Folder Include="Web\Resources\" /> CONTRIBUTING.md Generators README.md Samples Source Svg.Custom Tests doc docfx.json index.md license.txt Removed the commented Enums static class - Enums no longer needed.

Main Project Cleanup

e91c82b

- Clean up of the main source code project - Removed irrelevant files - Added support for .NET 4.7, .NET 4.8 - Removed preprocessor to enable events registration for all - Updates to the SvgOptions class to support property attributes

paulushub added the enhancement label Jan 14, 2024

paulushub requested a review from mrbean-bremen January 14, 2024 10:51

mrbean-bremen reviewed Jan 14, 2024

View reviewed changes

Untabify the project files

517f96c

- Applying the default "Format Document" introduces the tabs!

mrbean-bremen reviewed Jan 14, 2024

View reviewed changes

paulushub mentioned this pull request Jan 14, 2024

Added net6.0-windows to TFMs. #1019

Closed

paulushub added 2 commits January 14, 2024 22:04

Merge branch 'svg-net:master' into master

091f3a3

Restore the default interpolation mode of the GDI+ rendererer

54a9c47

- Set the default mode to InterpolationMode.Default

Further clean up

3d558d3

- Removed NuGet project files and folder - Removed non-existence folder: <Folder Include="Web\Resources\" />

H1Gdev reviewed Jan 16, 2024

View reviewed changes

Removed the commented Enums static class

e9702fa

- Enums no longer needed.

paulushub requested review from mrbean-bremen and H1Gdev January 16, 2024 04:22

paulushub self-assigned this Jan 16, 2024

mrbean-bremen approved these changes Jan 16, 2024

View reviewed changes

H1Gdev approved these changes Jan 17, 2024

View reviewed changes

paulushub merged commit 18cb5e4 into svg-net:master Jan 18, 2024
7 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Main Project Cleanup #1123

Main Project Cleanup #1123

paulushub commented Jan 14, 2024 •

edited

Loading

mrbean-bremen Jan 14, 2024

paulushub Jan 14, 2024

H1Gdev Jan 16, 2024

paulushub Jan 16, 2024

mrbean-bremen Jan 14, 2024

paulushub Jan 14, 2024

mrbean-bremen Jan 14, 2024

paulushub commented Jan 14, 2024

mrbean-bremen left a comment

paulushub commented Jan 14, 2024

mrbean-bremen commented Jan 14, 2024

paulushub commented Jan 14, 2024 •

edited

Loading

H1Gdev Jan 16, 2024

paulushub Jan 16, 2024

H1Gdev Jan 16, 2024

paulushub Jan 16, 2024

paulushub commented Jan 16, 2024 •

edited

Loading

		<DefineConstants Condition="$(TargetFramework.StartsWith('net47'))">$(DefineConstants);DOTNET47;NETFULL</DefineConstants>
		<DefineConstants Condition="$(TargetFramework.StartsWith('net48'))">$(DefineConstants);DOTNET48;NETFULL</DefineConstants>

Main Project Cleanup #1123

Main Project Cleanup #1123

Conversation

paulushub commented Jan 14, 2024 • edited Loading

Description

Type of change

How Has This Been Tested?

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

paulushub commented Jan 14, 2024

mrbean-bremen left a comment

Choose a reason for hiding this comment

paulushub commented Jan 14, 2024

mrbean-bremen commented Jan 14, 2024

paulushub commented Jan 14, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

paulushub commented Jan 16, 2024 • edited Loading

paulushub commented Jan 14, 2024 •

edited

Loading

paulushub commented Jan 14, 2024 •

edited

Loading

paulushub commented Jan 16, 2024 •

edited

Loading