-
Notifications
You must be signed in to change notification settings - Fork 476
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix declaring node also allows to use prefix for namespace #1106
Fix declaring node also allows to use prefix for namespace #1106
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, looks good! Please also add an entry in the release notes, and if possible, a test.
Test and changelog added @mrbean-bremen . Please keep in mind that the version and date in the changelog is just a placeholder XX yet and needs to be set accordingly at release. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
…ildProcessTemplates CONTRIBUTING.md Generators Nuget README.md Samples Source Svg.Custom Tests doc docfx.json index.md license.txt Fix declaring node also allows to use prefix for namespace BuildProcessTemplates CONTRIBUTING.md Generators Nuget README.md Samples Source Svg.Custom Tests doc docfx.json index.md license.txt Release notes written and changelog added BuildProcessTemplates CONTRIBUTING.md Generators Nuget README.md Samples Source Svg.Custom Tests doc docfx.json index.md license.txt Used string.Equals uniformly
) BuildProcessTemplates CONTRIBUTING.md Generators Nuget README.md Samples Source Svg.Custom Tests doc docfx.json index.md license.txt Fix declaring node also allows to use prefix for namespace BuildProcessTemplates CONTRIBUTING.md Generators Nuget README.md Samples Source Svg.Custom Tests doc docfx.json index.md license.txt Release notes written and changelog added BuildProcessTemplates CONTRIBUTING.md Generators Nuget README.md Samples Source Svg.Custom Tests doc docfx.json index.md license.txt Used string.Equals uniformly
Issue / problem
Writing a SVG file where the namespace of a node is declared as an attribute in this node fails to resolve the namespace prefix.
As a minimal example, assume we want to add some additional meta data to a SVG file:
The additional meta data will look like this:
Obviously the namespace here is mentioned twice which is not necessary since (see e.g. Oracle or w3resource)
which means namespace prefixes can be already used in the node they are declared.
This PR also takes care of this and looks up the namespaces declared in the nodes themselfes.