Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix(report): metrics reporter: prevent error by ignoring folders for which Ca/Ce/I can't be calculated #620

Conversation

sverweij
Copy link
Owner

Description

  • makes the metrics reporter ignore folders for which metrics couldn't be calculated.

Motivation and Context

If metrics were asked for folders for which I/Ca/Ce can't be calulated e.g. because they match the doNotFollow attribute (e.g. node_modules go typically in there) the metrics reporter borked with a cannot read xxx of yyy error. As it doesn't make sense to show
metrics for these folders they should've been left out in the first place - which is what this PR fixes.

How Has This Been Tested?

  • green ci
  • additional automated integration test

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Documentation only change
  • Refactor (non-breaking change which fixes an issue without changing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • 📖

    • My change doesn't require a documentation update, or ...
    • it does and I have updated it
  • ⚖️

    • The contribution will be subject to The MIT license, and I'm OK with that.
    • The contribution is my own original work.
    • I am ok with the stuff in CONTRIBUTING.md.

@sverweij sverweij added this to backlog in roadmap via automation Jun 10, 2022
@sverweij sverweij moved this from backlog to doing in roadmap Jun 10, 2022
…for which Ca/Ce/I can't be calculated

e.g. because they're in donotfollow, like typically stuff in node_modules
@sverweij sverweij force-pushed the bugfix/dont-attempt-to-show-noncalculable-metrics-in-metrics-reporter branch from ad2fc2e to 5c1bf9c Compare June 10, 2022 17:25
@sverweij sverweij merged commit d3a69bf into develop Jun 10, 2022
roadmap automation moved this from doing to shippable Jun 10, 2022
@sverweij sverweij deleted the bugfix/dont-attempt-to-show-noncalculable-metrics-in-metrics-reporter branch June 10, 2022 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: shippable
roadmap
  
shippable
Development

Successfully merging this pull request may close these issues.

None yet

1 participant