Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(metrics): calculate metrics when the current reporter's option specifies to show them #617

Conversation

sverweij
Copy link
Owner

@sverweij sverweij commented Jun 9, 2022

Description

  • calculate metrics when the current reporter's option specifies to show them

Motivation and Context

It's non-obvious when showMetrics === true for a reporter but they don't show up. The original reason for this behaviour was to prevent unexpected performance hits. However, when you set showMetrics to true in a reporter you either take that for granted or don't care either way.

Fixes #610

How Has This Been Tested?

  • green ci
  • additional automated tests

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Documentation only change
  • Refactor (non-breaking change which fixes an issue without changing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • 📖

    • My change doesn't require a documentation update, or ...
    • it does and I have updated it
  • ⚖️

    • The contribution will be subject to The MIT license, and I'm OK with that.
    • The contribution is my own original work.
    • I am ok with the stuff in CONTRIBUTING.md.

@sverweij sverweij merged commit 3fff445 into develop Jun 9, 2022
@sverweij sverweij deleted the feature/calculate-metrics-when-current-reporter-options-specify-so branch June 9, 2022 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: shippable
Development

Successfully merging this pull request may close these issues.

Issue: show metrics does not render number of lines
1 participant