feature(metrics): calculate metrics when the current reporter's option specifies to show them #617
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
It's non-obvious when
showMetrics === true
for a reporter but they don't show up. The original reason for this behaviour was to prevent unexpected performance hits. However, when you set showMetrics to true in a reporter you either take that for granted or don't care either way.Fixes #610
How Has This Been Tested?
Types of changes
Checklist
📖
⚖️