Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error Message Color (basic implementation) #121

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

sornig
Copy link
Contributor

@sornig sornig commented Apr 17, 2024

Added a way to customize the color of calculator error messages, as described in #85.
Also added a bit of documentation for the new option.

@sornig sornig mentioned this pull request Apr 17, 2024
@svenstaro
Copy link
Owner

Hm would it perhaps be more proper to use the theme colors? It might be unexpected for people to be able to customize everything via theming option but then have to use a cli flag for a single color.

@sornig
Copy link
Contributor Author

sornig commented Apr 17, 2024

That would probably be the ideal implementation, but as I said, I kind of don't know how to do it or where to start. Also, looking at the activity in #85, I get the impression that this is more of a niche feature anyway rather than something many users have been actively requesting. Maybe I find some time in the future to look deeper into this, but I haven't really worked with rofi source code before and am far from what one would consider skilled when it comes to C ...

@sornig
Copy link
Contributor Author

sornig commented Apr 17, 2024

Also, this is exactly the way -hint-welcome and -hint-result are currently implemented.
If we eventually find a way to customize -calc-error-color through the config.rasi, then these could get reworked as well.

Since most people put their rofi command(s) into some hotkey daemon (e.g. sxhkd) anyway, I don't see why appending this (optional) property to the already existing -no-show-match and -no-sort would be a huge problem.

EDIT: -no-sort is of course a rofi option and not plugin-specific but the two options are recommended in the README


also (completely unrelated to this issue/pr): -no-show-match apparently doesn't exist (anymore) – is this the option that is/was supposed to suppress the search highlighting of history items? If that is the case, i guess this needs its own issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants