Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow destructured defaults to refer to variables #5986

Merged
merged 8 commits into from
Feb 25, 2021
Merged

allow destructured defaults to refer to variables #5986

merged 8 commits into from
Feb 25, 2021

Conversation

tanhauhau
Copy link
Member

Fixed #5066

Continued from #5230, added support to refer to other variables, besides destructured params, and more tests

Before submitting the PR, please make sure you do the following

  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with npm test and lint the project with npm run lint

@Conduitry Conduitry merged commit d17a90c into sveltejs:master Feb 25, 2021
@Conduitry Conduitry mentioned this pull request Feb 25, 2021
Closed
4 tasks
This was referenced Mar 8, 2021
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

{#each} block destructuring can't have default values refer to destructured params
3 participants
@tanhauhau @Conduitry @habibrosyad