Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cache call expressions in render tag arguments #12418

Merged
merged 4 commits into from
Jul 12, 2024

Conversation

dummdidumm
Copy link
Member

Ensure that they're called at most once per change, not once per access within the snippet
fixes #12187

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Ensure that they're called at most once per change, not once per access within the snippet
fixes #12187
Copy link

changeset-bot bot commented Jul 12, 2024

🦋 Changeset detected

Latest commit: 88ee490

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Rich-Harris
Copy link
Member

I think we should avoid walking up the tree inside visitors, it's a lot of unnecessary work to do every time we encounter a CallExpression. Can we put the current render tag on state instead? That's what state is for

@dummdidumm
Copy link
Member Author

Yeah I can change that - it felt stupid to add to state for just that reason, but it is what it is.

@Rich-Harris Rich-Harris merged commit 70cec4e into main Jul 12, 2024
9 checks passed
@Rich-Harris Rich-Harris deleted the render-tags-call-expr branch July 12, 2024 17:03
trueadm pushed a commit that referenced this pull request Jul 16, 2024
* fix: cache call expressions in render tag arguments

Ensure that they're called at most once per change, not once per access within the snippet
fixes #12187

* leverage state

* types

* fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Svelte5: snippets components invoked multiple times
3 participants