Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: runtime dev warn for mismatched @html #12396

Merged
merged 8 commits into from
Jul 10, 2024

Conversation

paoloricciuti
Copy link
Member

Svelte 5 rewrite

My shot at closing #12362

I hope i did everything correctly and it seems to work but I'm obviously totally open to feedback.

Please note that the Svelte codebase is currently being rewritten for Svelte 5. Changes should target Svelte 5, which lives on the default branch (main).

If your PR concerns Svelte 4 (including updates to svelte.dev.docs), please ensure the base branch is svelte-4 and not main.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Copy link

changeset-bot bot commented Jul 10, 2024

🦋 Changeset detected

Latest commit: 49808f8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Rich-Harris
Copy link
Member

Made a couple of tweaks:

  • move the logic into a helper, modeled after the ones in client/dom/blocks. I'd like to move more server runtime logic into modules like these, since at the moment we have a lot of logic in one place
  • added location information to make it easier to find the offending block
  • removed the value from the warning. It's a nice idea, but HTML typically contains things like new lines, and there's really no way to reliably make it look good

@Rich-Harris
Copy link
Member

thanks!

@paoloricciuti
Copy link
Member Author

Made a couple of tweaks:

  • move the logic into a helper, modeled after the ones in client/dom/blocks. I'd like to move more server runtime logic into modules like these, since at the moment we have a lot of logic in one place
  • added location information to make it easier to find the offending block
  • removed the value from the warning. It's a nice idea, but HTML typically contains things like new lines, and there's really no way to reliably make it look good

Great changes, thanks for the feedback! 🙏🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dev-time check for {@html ...} mismatch
2 participants