Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure hmr block effects are transparent for transitions #12384

Merged
merged 2 commits into from
Jul 10, 2024

Conversation

trueadm
Copy link
Contributor

@trueadm trueadm commented Jul 10, 2024

Fixes #12358

Copy link

changeset-bot bot commented Jul 10, 2024

🦋 Changeset detected

Latest commit: 315e6e3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dummdidumm
Copy link
Member

A test case would be good (you can enable HMR and dev through the compileOptions property of a test)

@trueadm
Copy link
Contributor Author

trueadm commented Jul 10, 2024

A test case would be good (you can enable HMR and dev through the compileOptions property of a test)

Nice! Didn't know we had hmr support already. Added a test.

@Rich-Harris Rich-Harris merged commit 125156d into main Jul 10, 2024
9 checks passed
@Rich-Harris Rich-Harris deleted the hmr-transparent branch July 10, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Svelte 5: intro transition doesn't work in dev mode
3 participants