Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: stricter control flow syntax validation in runes mode #12342

Merged
merged 1 commit into from
Jul 8, 2024

Conversation

dummdidumm
Copy link
Member

@dummdidumm dummdidumm commented Jul 8, 2024

Handle whitespace characters between { and # / : / @ but disallow that in runes mode

closes #11975

While implementing this I noticed that the else if block AST is too ambiguous right now. Is a fragment with a sole if block an else if or a if? it's indistinguishable, which is bad for formatting tools like prettier. We should change it to the if block AST being directly placed inside the alternate branch. Will do that if others agree as a follow-up once this is merged.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

disallow characters between `{` and `#` / `:` / `@` in runes mode

closes #11975
Copy link

changeset-bot bot commented Jul 8, 2024

🦋 Changeset detected

Latest commit: 7b556e7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Rich-Harris
Copy link
Member

Is a fragment with a sole if block an else if or a if? it's indistinguishable, which is bad for formatting tools like prettier

Not sure I understand what you mean here, can you elaborate? FWIW these are different (with respect to transition locality):

{#if foo}...{:else}{#if bar}...{/if}{/if}

{#if foo}...{:else if bar}...{/if}

@Rich-Harris Rich-Harris merged commit 14cbb65 into main Jul 8, 2024
9 checks passed
@Rich-Harris Rich-Harris deleted the control-flow-stricter-validation branch July 8, 2024 15:28
@dummdidumm
Copy link
Member Author

dummdidumm commented Jul 8, 2024

I forgot there's the elseif property - ignore me 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Svelte 5: Incorrect IfBlock Start Position in Modern Mode Parsing
3 participants