fix: handle duplicate signal dependencies gracefully #12261
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #12245. Fixes #12230. This also permits duplicate dependencies and instead we avoid processing duplicates in
remove_reactions
. This means far less work is done on the fast normal path, and instead we just do a bit more work when removing signals.This PR faster in almost all the benchmarks than
main
for me, and the ones it is not it's off by a small fraction which shows that the codepath likely isn't being hit.