Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure HMR doesn't mess with anchor nodes #12242

Merged
merged 1 commit into from
Jul 1, 2024
Merged

fix: ensure HMR doesn't mess with anchor nodes #12242

merged 1 commit into from
Jul 1, 2024

Conversation

dummdidumm
Copy link
Member

@dummdidumm dummdidumm commented Jul 1, 2024

The refactoring in #12215 didn't take HMR into account. As a result, the anchor was passed to the HMR block, which was subsequently cleaned up on destroy - but the anchor could be shared with other components and therefore needs to stay in the dom. Passing null instead solves the problem.
Fixes #12228
Fixes #12230
Fixes #12233

The test simulated what SvelteKit does, where this bug manifests the most prominent on page changes.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

The refactoring in #12215 didn't take HMR into account. As a result, the anchor was passed to the HMR block, which was subsequently cleaned up on destroy - but the anchor could be shared with other components and therefore needs to stay in the dom. Passing `null` instead solves the problem.
Fixes #12228
@dummdidumm dummdidumm marked this pull request as ready for review July 1, 2024 08:40
Copy link

changeset-bot bot commented Jul 1, 2024

🦋 Changeset detected

Latest commit: aa1720c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant