Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: dedupe safe_not_equal in svelte/store #12160

Merged
merged 2 commits into from
Jun 24, 2024

Conversation

Conduitry
Copy link
Member

While looking at a bundled app that used stores, I noticed I had both safe_not_equal and safe_not_equal$1 - each having almost identical implementations. I don't think there's any reason for stores to need their own copy. This switches them over to using the same copy as is used elsewhere.

Svelte 5 rewrite

Please note that the Svelte codebase is currently being rewritten for Svelte 5. Changes should target Svelte 5, which lives on the default branch (main).

If your PR concerns Svelte 4 (including updates to svelte.dev.docs), please ensure the base branch is svelte-4 and not main.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Copy link

changeset-bot bot commented Jun 24, 2024

⚠️ No Changeset found

Latest commit: d6d5b5e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dummdidumm
Copy link
Member

ha, by coincide I also noticed something related; this will give a merge conflict soon but you can easily resolve it once I merged the other dts-buddy PR

@dummdidumm dummdidumm merged commit fd6dd45 into sveltejs:main Jun 24, 2024
7 of 9 checks passed
@Conduitry Conduitry deleted the dedupe-safe_not_equal branch June 24, 2024 10:47
FoHoOV pushed a commit to FoHoOV/svelte that referenced this pull request Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants