Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename legacy.componentApi to compatibility.classComponent #12112

Closed
Rich-Harris opened this issue Jun 20, 2024 · 1 comment · Fixed by #12370
Closed

Rename legacy.componentApi to compatibility.classComponent #12112

Rich-Harris opened this issue Jun 20, 2024 · 1 comment · Fixed by #12370
Milestone

Comments

@Rich-Harris
Copy link
Member

Describe the problem

We replaced the Svelte 4 legacy option (which added IE compatibility at the cost of bloatier output) with a completely different legacy option. Per #12100, this is a bit confusing.

Describe the proposed solution

Rename legacy.componentApi to compatibility.classComponent (but keep classComponent deprecated).

I'm not 100% sure this is the right name, since it also affects SSR output (which was never a class, just an object), so am open to alternatives.

Importance

nice to have

@abdelfattahradwan
Copy link

How about compatibility.legacyComponent? This name seems to convey better that the feature provides legacy compatibility without implying that it's tied to a specific implementation (like class components). It also maintains consistency by keeping the "legacy" part of the name, which might be less confusing for users familiar with the current terminology.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants