fix: memory leak in unmount where document event listeners are not be…

…ing removed (#12101) * Fix memory leak in unmount where document event listeners are not being removed * changeset --------- Co-authored-by: Mark Siano <[email protected]> Co-authored-by: Rich Harris <[email protected]> Co-authored-by: Rich Harris <[email protected]>
sveltejs · Jun 24, 2024 · 752f872 · 752f872
1 parent 2814e9e
commit 752f872
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/.changeset/bright-berries-smell.md b/.changeset/bright-berries-smell.md
@@ -0,0 +1,5 @@
+---
+"svelte": patch
+---
+
+fix: remove correct event listener from document
diff --git a/packages/svelte/src/internal/client/render.js b/packages/svelte/src/internal/client/render.js
@@ -265,7 +265,7 @@ function _mount(Component, { target, anchor, props = {}, events, context, intro
  return () => {
  for (const event_name of registered_events) {
  target.removeEventListener(event_name, bound_event_listener);
- document.removeEventListener(event_name, bound_event_listener);
+ document.removeEventListener(event_name, bound_document_event_listener);
  }
  root_event_handles.delete(event_handle);
  mounted_components.delete(component);