chore: use playwright test runner for adapter-static tests
#9873
Conversation
|
Co-authored-by: gtmnayan <[email protected]>
| test('generates HTML files', () => { | ||
| expect(fs.existsSync(`${cwd}/build/index.html`)).toBeTruthy(); | ||
| }); |
There was a problem hiding this comment.
feels kinda weird to use playwright for tests like these, no? should we split the tests up, or do you think that adds too much complexity?
There was a problem hiding this comment.
yeah, it did feel slightly weird, but there are so few of them. I think it's simpler with just a single test runner. we can always revisit if we add more non-browser tests
There was a problem hiding this comment.
fair enough — that weirdness aside, this is much nicer
This is a less code and easier to understand as it doesn't mix two test frameworks together. If we wanted to switch
uvuwithvitestthis would be one less package to convert and one of the hardest ones to address