Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use @clack/prompts #9219

Merged
merged 3 commits into from
Feb 27, 2023
Merged

feat: use @clack/prompts #9219

merged 3 commits into from
Feb 27, 2023

Conversation

Rich-Harris
Copy link
Member

Thought I'd have a go at using @clack/prompts to make the create-svelte experience slightly more polished.

Before:

image

After:

image

@Rich-Harris Rich-Harris changed the title use @clack/prompts feat: use @clack/prompts Feb 26, 2023
@benmccann
Copy link
Member

Is there a way to test this locally and see what the new experience is like?

@Rich-Harris
Copy link
Member Author

yes, just run bin.js

../kit/packages/create-svelte/bin.js

Copy link
Member

@dummdidumm dummdidumm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the change! The "select what you want" for the optional things instead of a chain of yes/no is better, even if it requires some unlearning for existing users.
Is there anything fancy we want to add while we're at it? Ascii-Svelte-logo or sth like that.

.changeset/mighty-cars-wave.md Outdated Show resolved Hide resolved
packages/create-svelte/bin.js Show resolved Hide resolved
@Rich-Harris
Copy link
Member Author

Is there anything fancy we want to add while we're at it? Ascii-Svelte-logo or sth like that.

I thought about it but it feels a bit gimmicky and doesn't work with very narrow terminals — I think we should respect the user's screen real estate as well as their time by making everything as compact and direct as possible

Copy link
Member

@dummdidumm dummdidumm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@shinokada
Copy link

shinokada commented Mar 1, 2023

I can't select options.
How can I select them/all?
Some more instruction on how to select is helpful.
image

@shinokada
Copy link

Ok, I found it out. You need to press the space to select it.

@Antonio-Bennett
Copy link

@shinokada Literally tracked down this PR to ask about this as well :) Definetly needs more clear instruction here @Rich-Harris

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants