Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use new locator api for demo tests #8988

Merged
merged 1 commit into from
Feb 10, 2023

Conversation

debs-obrien
Copy link
Contributor

@debs-obrien debs-obrien commented Feb 10, 2023

using new locator apis new from version 1.27

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

using new locator apis new from version 1.27
@Rich-Harris Rich-Harris merged commit 4f7e12f into sveltejs:master Feb 10, 2023
@github-actions github-actions bot mentioned this pull request Feb 10, 2023
@debs-obrien debs-obrien deleted the fix/demo-test branch February 13, 2023 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants