Use satisfies operator

[benmccann]

sucrase, prettier, and eslint all support TypeScript 4.9 now. However, it looks like VS Code is still on 4.8.4

[changeset-bot]

🦋 Changeset detected

Latest commit: a22fb66

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
create-svelte	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[Rich-Harris]

Game was moved into a separate file the other day so that it could be unit-tested. Looks like it's now duplicated?

[benmccann]

Yeah, I caught that right as you did. I've updated this. Going to mark it as draft until VS Code supports TypeScript 4.9, but I think it's otherwise ready to go

[benmccann]

VS Code now supports TypeScript 4.9 and satisfies: https://code.visualstudio.com/updates/v1_74#_typescript-49

Mine just updated to include support for it

[Rich-Harris]

The docs still convert this...

...into this when you opt into TypeScript mode:

Ideally it would be export async function load(...) {...} satisifes PageServerLoad. Is it worth trying to get that working before merging this, so that we're singing from the same hymn sheet everywhere? @dummdidumm how complex would that be?

[dummdidumm]

Not that complex, but it's not going to be export async function load(...) {...} satisifes PageServerLoad (that's sadly not supported yet for some reason), it's going to be export const load = (async (...) => {...}) satisifes PageServerLoad

[Rich-Harris]

ah yeah, turned out it was actually very simple: #8001. unfortunately the site doesn't build with that change, hence separate branch rather than a commit to this one

[dummdidumm]

Giving this my approval, but a little hesitant to merge it just now. I'm not sure how fast/how many devs will have the latest VS Code version, so a good percentage could be confused by that not working in their editor.

[Rich-Harris]

I feel like we ought to wait until the docs are in sync anyway

[dummdidumm]

They are now, I merged your PR into this one

[Rich-Harris]

oh! i totally missed that. nice. how long should we wait? I feel like VSCode updates probably propagate quite quickly, though I'm not sure if there's a way to check. Part of me thinks that a couple of questions in Discord/etc is a reasonable price to pay for smoother typechecking for people checking out 1.0 for the first time

[benmccann]

I think I would lean towards trying to get this in now because a bunch of people will be trying to write tutorials, post/answer StackOverflow questions, etc. and all that content will be using outdated syntax if we release 1.0 without this. Merging this now will cause more questions on Discord from people who haven't updated VS Code yet, but I think it's probably the lesser of two evils and just a temporary hiccup

[524c]

I'm watching this final race towards 1.0 🚀
I noticed that there is a typo in the title of this PR...

[benmccann]

updated the title. luckily I got the changeset right first time around