Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade dependencies #7852

Merged
merged 6 commits into from
Nov 28, 2022
Merged

Upgrade dependencies #7852

merged 6 commits into from
Nov 28, 2022

Conversation

benmccann
Copy link
Member

I think only adapter-auto and create-svelte need an updated changeset

@changeset-bot
Copy link

changeset-bot bot commented Nov 28, 2022

🦋 Changeset detected

Latest commit: 8cc77dd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@sveltejs/adapter-auto Patch
create-svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@@ -30,10 +30,11 @@
"check": "tsc"
},
"devDependencies": {
"@types/node": "^16.11.68",
"typescript": "^4.8.4"
"@sveltejs/kit": "workspace:*",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this dependency is new, is it needed? it's referenced in index.d.ts but that was previously taken care of by the "paths" in tsconfig.json. maybe this way is better, idk, but presumably we'd want to update that config?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's what I get without it:

Screenshot from 2022-11-28 12-50-42

I just removed the paths config instead

@@ -29,13 +29,13 @@
"check": "tsc"
},
"dependencies": {
"@cloudflare/workers-types": "^4.0.0",
"@cloudflare/workers-types": "^4.20221111.1",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

holy shit really? 🤔

Copy link
Member

@Rich-Harris Rich-Harris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just had one minor query

@Rich-Harris Rich-Harris merged commit 581c43e into sveltejs:master Nov 28, 2022
@benmccann benmccann deleted the upgrade-deps branch November 28, 2022 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants