Warn if %sveltekit.body% is a direct child of <body>
#7652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 8c086fd The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Conduitry
reviewed
Nov 14, 2022
Conduitry
reviewed
Nov 14, 2022
Conduitry
reviewed
Nov 14, 2022
Comment on lines
+22
to
+26
| if (__SVELTEKIT_DEV__ && target === document.body) { | ||
| console.warn( | ||
| `Placing %sveltekit.body% directly inside <body> is not recommended, as your app may break for users who have certain browser extensions installed.\n\nConsider wrapping it in an element:\n\n<div style="display: contents">\n %sveltekit.body%\n</div>` | ||
| ); | ||
| } |
There was a problem hiding this comment.
Do we want to coordinate anything with the documentation at https://kit.svelte.dev/docs/project-structure#project-files-src ? Should this message link you to any docs? Should the docs say that this will produce a warning?
There was a problem hiding this comment.
updated the docs, but i don't think it's worth linking to them because they don't provide any additional information
Co-authored-by: Conduitry <[email protected]>
Conduitry
approved these changes
Nov 15, 2022
kyoshino
added a commit
to videomark/videomark.webdino.org
that referenced
this pull request
Nov 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#7585. In addition to the warning, it adds
display: contentsto the wrapper elements in the template appsPlease don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm testand lint the project withpnpm lintandpnpm checkChangesets
pnpm changesetand following the prompts. All changesets should bepatchuntil SvelteKit 1.0