Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feat] more info about prerendering errors and new strict option #7264

Merged
merged 10 commits into from
Oct 18, 2022
Merged

[feat] more info about prerendering errors and new strict option #7264

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
88b7823
[fix] more info about prerendering errors
dummdidumm Oct 14, 2022
822b639
Apply suggestions from code review
Rich-Harris Oct 16, 2022
470ae89
swap ternary around, remove dead code
Rich-Harris Oct 16, 2022
cd4575c
small tweak
Rich-Harris Oct 16, 2022
6eacaab
another minor tweak
Rich-Harris Oct 16, 2022
505979b
drive-by-fix
dummdidumm Oct 17, 2022
d5e1347
tweak when prerender.entries suggestion appears
dummdidumm Oct 17, 2022
d437e8c
tweak
dummdidumm Oct 17, 2022
d46e545
add strict option
dummdidumm Oct 17, 2022
02d41ac
Apply suggestions from code review
Rich-Harris Oct 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
drive-by-fix
  • Loading branch information
@dummdidumm
dummdidumm committed Oct 17, 2022
commit 505979bf06561263b72f77dfe5120ef0fe3f14b7
3 changes: 2 additions & 1 deletion packages/kit/src/core/adapt/builder.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,10 +33,11 @@ export function create_builder({ config, build_data, routes, prerendered, log })
async createEntries(fn) {
/** @type {import('types').RouteDefinition[]} */
const facades = routes.map((route) => {
/** @type {Set<import('types').HttpMethod>} */
const methods = new Set();

if (route.page) {
methods.add('SET');
methods.add('GET');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol oops

}

if (route.endpoint) {
Expand Down