Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(create-svelte): Add $service-worker to paths in tsconfig.json #716

Merged
merged 4 commits into from
Mar 27, 2021

Conversation

Liamolucko
Copy link
Contributor

Adds $service-worker to paths in the template's tsconfig.json so service workers can be properly type-checked. I also had to add noEmit because TypeScript was complaining about overwriting .svelte/build/runtime/service-worker.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpx changeset and following the prompts

I also had to add `noEmit` because TypeScript was complaining about overwriting .svelte/build/runtime/service-worker.
@vercel
Copy link

vercel bot commented Mar 27, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/sveltejs/kit/9EFZkSELsuz2U8Q4TiqQ8kLAekUq
✅ Preview: Canceled

[Deployment for 236f542 canceled]

@dummdidumm
Copy link
Member

Thanks! I removed the emit line though because I cannot reproduce this and it seems like a non-ideal solution to just flip this flag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants