Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] bump TS to 4.8 #6428

Merged
merged 2 commits into from
Aug 30, 2022
Merged

[chore] bump TS to 4.8 #6428

merged 2 commits into from
Aug 30, 2022

Conversation

dummdidumm
Copy link
Member

Fixes a breaking change introduced by TS: NonNullable is no longer never when strict null checks are false: microsoft/TypeScript#50519

Closes #6387
This isn't a breaking change because everything is backwards compatible and only new users of create-svelte get a higher version (but it works with the older one, too)

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

Fixes a breaking change introduced by TS: NonNullable<null> is no longer never when strict null checks are false: microsoft/TypeScript#50519
@changeset-bot
Copy link

changeset-bot bot commented Aug 30, 2022

🦋 Changeset detected

Latest commit: fb7b676

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
create-svelte Patch
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@benmccann benmccann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for figuring this out!!

@dummdidumm dummdidumm merged commit 7f69c52 into master Aug 30, 2022
@dummdidumm dummdidumm deleted the bump-ts branch August 30, 2022 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to TypeScript 4.8
2 participants