Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow server-only load functions to return more than JSON #6318

Merged
merged 25 commits into from
Aug 29, 2022
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixes
  • Loading branch information
Rich-Harris committed Aug 26, 2022
commit 8481a6a3a42888cf044cdfa7f0576dcf387aa0e1
2 changes: 1 addition & 1 deletion packages/kit/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
"dependencies": {
"@sveltejs/vite-plugin-svelte": "^1.0.1",
"cookie": "^0.5.0",
"devalue": "^3.1.0",
"devalue": "^3.1.1",
"kleur": "^4.1.4",
"magic-string": "^0.26.2",
"mime": "^3.0.0",
Expand Down
26 changes: 19 additions & 7 deletions packages/kit/src/runtime/client/client.js
Original file line number Diff line number Diff line change
Expand Up @@ -393,7 +393,7 @@ export function create_client({ target, base, trailing_slash }) {
* status: number;
* error: HttpError | Error | null;
* routeId: string | null;
* validation_errors?: string | undefined;
* validation_errors?: Record<string, any> | null;
* }} opts
*/
async function get_navigation_result_from_branch({
Expand Down Expand Up @@ -1272,7 +1272,7 @@ export function create_client({ target, base, trailing_slash }) {

_hydrate: async ({
status,
error,
error: original_error, // TODO get rid of this
node_ids,
params,
routeId,
Expand All @@ -1286,6 +1286,16 @@ export function create_client({ target, base, trailing_slash }) {

try {
const branch_promises = node_ids.map(async (n, i) => {
const server_data_node = server_data_nodes[i];

if (server_data_node?.type === 'error') {
if (server_data_node.httperror) {
throw error(server_data_node.httperror.status, server_data_node.httperror.message);
}

throw server_data_node.error;
}
dummdidumm marked this conversation as resolved.
Show resolved Hide resolved

return load_node({
loader: nodes[n],
url,
Expand All @@ -1298,7 +1308,7 @@ export function create_client({ target, base, trailing_slash }) {
}
return data;
},
server_data_node: create_data_node(server_data_nodes[i])
server_data_node: create_data_node(server_data_node)
});
});

Expand All @@ -1307,13 +1317,15 @@ export function create_client({ target, base, trailing_slash }) {
params,
branch: await Promise.all(branch_promises),
status,
error: /** @type {import('../server/page/types').SerializedHttpError} */ (error)
error: /** @type {import('../server/page/types').SerializedHttpError} */ (original_error)
?.__is_http_error
? new HttpError(
/** @type {import('../server/page/types').SerializedHttpError} */ (error).status,
error.message
/** @type {import('../server/page/types').SerializedHttpError} */ (
original_error
).status,
original_error.message
)
: error,
: original_error,
validation_errors,
routeId
});
Expand Down
2 changes: 1 addition & 1 deletion packages/kit/src/runtime/client/types.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ export interface Client {
params: Record<string, string>;
routeId: string | null;
data: Array<import('types').ServerDataNode | import('types').ServerErrorNode | null>;
errors: Record<string, any>;
errors: Record<string, any> | null;
}) => Promise<void>;
_start_router: () => void;
}
Expand Down
8 changes: 4 additions & 4 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.