Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement #5748 #5778

Merged
merged 192 commits into from
Aug 15, 2022
Merged

Implement #5748 #5778

merged 192 commits into from
Aug 15, 2022

Conversation

Rich-Harris
Copy link
Member

@Rich-Harris Rich-Harris commented Aug 1, 2022

Edited: this now incorporates #5782 and #5810.

This PR implements #5748. The migration guide is available at #5774.

  • use the app's installed TypeScript rather than including it in SvelteKit (i.e. don't generate types otherwise)
  • create types for parent
  • make write_types work incrementally
  • update the docs
    • document POST, PATCH, PUT and DELETE in +page.server.js
    • get search working for +page etc
    • 'The following types can be imported from @sveltejs/kit' is wrong in the modules section
  • get all the tests passing
  • ensure all the migration guides are correct
  • investigate why client-side navigation fails on the preview deployment
  • rename GET to load in +page|layout.server.js (POST etc can stay, pending resolution of Semantic form actions, and easier progressive enhancement #5875)
  • remove session, per Removing `session` #5883
  • implement invalidate() (i.e. re-run all load functions, if no argument is specified)
  • update types inside migrated files (+page.server.js should have PageServerLoad etc)
  • error if project has not been migrated
  • mother of all changesets (including for svelte-migrate and create-svelte etc)

@changeset-bot
Copy link

changeset-bot bot commented Aug 1, 2022

🦋 Changeset detected

Latest commit: 99690ae

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Rich-Harris Rich-Harris merged commit b30d2b6 into master Aug 15, 2022
@Rich-Harris Rich-Harris deleted the migrate-tests branch August 15, 2022 21:25
@Rich-Harris Rich-Harris mentioned this pull request Aug 15, 2022
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants