Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert #5012 #5121

Merged
merged 9 commits into from
May 30, 2022
Merged

Revert #5012 #5121

merged 9 commits into from
May 30, 2022

Conversation

Rich-Harris
Copy link
Member

#5012 was a mistake. The whole point of something like pnpm is that it makes duplicate dependencies free. When you put everything in the root, you make it impossible to know which packages are affected by a given upgrade. You also make it harder to identify unused packages.

I added a script, node scripts/check-dependencies.js, that makes it easy to find mismatched versions. We could add it as a CI check that fails if mismatches are found, if we want.

@changeset-bot
Copy link

changeset-bot bot commented May 30, 2022

🦋 Changeset detected

Latest commit: 1508d27

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
@sveltejs/adapter-auto Patch
@sveltejs/adapter-cloudflare Patch
@sveltejs/adapter-cloudflare-workers Patch
@sveltejs/adapter-netlify Patch
@sveltejs/adapter-node Patch
@sveltejs/adapter-static Patch
@sveltejs/adapter-vercel Patch
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Rich-Harris Rich-Harris mentioned this pull request May 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant