Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Svelte: Default App CSS fix #4390

Merged

Conversation

aMediocreDad
Copy link
Contributor

@aMediocreDad aMediocreDad commented Mar 19, 2022

This is a simple change to the CSS in the skeleton app.

To test the issue, access any of the kit-demo links (e.g. https://cloudflare.demo.svelte.dev/) on an iOS device and attempt to tap the counter button multiple times. It will result in the page zooming in due to the native "double-tap-to-zoom" interaction on iOS.

Adding touch-action: manipulation to the button's css will disable the "double-tap-to-zoom"-interaction when tapping the buttons.

That is all.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it. (Not aware that this is possible to test)

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpx changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

@changeset-bot
Copy link

changeset-bot bot commented Mar 19, 2022

🦋 Changeset detected

Latest commit: 6c0288f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
create-svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@Rich-Harris Rich-Harris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL! Thank you

.changeset/lemon-keys-run.md Outdated Show resolved Hide resolved
.changeset/lemon-keys-run.md Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants