Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .ts files in create-svelte/shared to both +typescript and -typescript (as .js files) #4368

Merged
merged 3 commits into from
Mar 17, 2022

Conversation

Rich-Harris
Copy link
Member

@Rich-Harris Rich-Harris commented Mar 17, 2022

Alternative to #4365. With this PR, instead of needing to maintain parallel test/test.ts and test/test.js files (or whatever other stuff gets added in future), we can just have a .ts file in a shared directory that doesn't specify typescript, and it will get added to both +typescript and -typescript variants, appropriately converted in the latter case.

fixes #4341. closes #4365

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpx changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

@changeset-bot
Copy link

changeset-bot bot commented Mar 17, 2022

🦋 Changeset detected

Latest commit: ebe5af8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
create-svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@benmccann benmccann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know if there's any sort of test we should have for this?

@Rich-Harris
Copy link
Member Author

re tests — maybe, though I kinda feel like that applies to the package as a whole. one day

@Rich-Harris Rich-Harris merged commit 4e53c51 into master Mar 17, 2022
@Rich-Harris Rich-Harris deleted the playwright-typescript-alt branch March 17, 2022 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeScript installation works with tests/test.ts, not tests/test.js
2 participants