Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove target option #3674

Merged
merged 5 commits into from
Feb 2, 2022
Merged

Remove target option #3674

merged 5 commits into from
Feb 2, 2022

Conversation

Rich-Harris
Copy link
Member

Ref #2221. This simplifies svelte.config.js and src/app.html, and removes the tight coupling between them, by getting rid of the target option. Instead, the init script hydrates the init script's parentNode. As a bonus, it makes it easier to embed multiple SvelteKit apps on a single page, for the rare cases where that's necessary.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpx changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

@changeset-bot
Copy link

changeset-bot bot commented Feb 2, 2022

🦋 Changeset detected

Latest commit: 2b61a31

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
create-svelte Patch
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify
Copy link

netlify bot commented Feb 2, 2022

✔️ Deploy Preview for kit-demo canceled.

🔨 Explore the source changes: 2b61a31

🔍 Inspect the deploy log: https://app.netlify.com/sites/kit-demo/deploys/61fa8c18eb542c000770f1b9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants