Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: bump eslint ecmaVersion to 2020 #2985

Merged
merged 2 commits into from
Dec 8, 2021
Merged

feat: bump eslint ecmaVersion to 2020 #2985

merged 2 commits into from
Dec 8, 2021

Conversation

josefaidt
Copy link
Contributor

@josefaidt josefaidt commented Dec 5, 2021

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpx changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

Description

reference #2984

Bumps eslint ecmaVersion to 2020, enables usage of import.meta.env in JS files without error

@changeset-bot
Copy link

changeset-bot bot commented Dec 5, 2021

🦋 Changeset detected

Latest commit: 24c0e52

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
create-svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@bluwy bluwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this ready for review? From a glance it looks good to me. We may want a changeset for this as well.

@josefaidt
Copy link
Contributor Author

Hey @bluwy I think it's ready for review! I was a bit hesitant to open the PR for review prior to the corresponding issue triage/discussion

@josefaidt josefaidt marked this pull request as ready for review December 6, 2021 20:50
Copy link
Member

@bluwy bluwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have not verified the linting error myself, so I'm trusting that this fixes it :) But I don't think it would hurt either way since 2022 is just around the corner.

Copy link
Member

@benmccann benmccann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we set everything to es2020 in #2604, but looks like this was a place that got overlooked

@benmccann benmccann merged commit ae7f790 into sveltejs:master Dec 8, 2021
@github-actions github-actions bot mentioned this pull request Dec 8, 2021
@benmccann
Copy link
Member

instead of reference #2984 if you say fixes #2984 or closes #2984 then github will link the issue and PR to automatically close the issue when the PR is merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants