fix: Prettier not formatting .svelte files

[caesar]

Adds --plugin-search-dir=. param to Prettier call in package.json scripts, so that Prettier will format .svelte files as well as .ts, .js, etc.

I assume Prettier is intended to be applied to .svelte files, since prettier-plugin-svelte is installed.

Fixes #1358.

Before submitting the PR, please make sure you do the following

• It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
• This message body should clearly illustrate what problems it solves.
• Ideally, include a test that fails without this PR but passes with it.

Tests

• Run the tests with pnpm test and lint the project with pnpm lint

Changesets

• If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpx changeset and following the prompts

[Rich-Harris]

Thanks, but I can't reproduce this — if I run npm run format in a fresh project, my .svelte files are formatted correctly. What am I missing?

[caesar]

That's very odd. As described in #1358 this is reproducible for me with a fresh project.
The only thing I can think of is pnpm vs npm (I used pnpm), but I can't see why it would make a difference.
I'll see if I can work it out…

[caesar]

As a side note, https://github.com/sveltejs/prettier-plugin-svelte#how-to-use-cli does suggest using --plugin-search-dir=. so it's not just me 🙂

[Conduitry]

I can reproduce this issue when installing dependencies with pnpm, but not when installing them with npm. With npm. npm run format also gets the .svelte files.

[caesar]

@Conduitry I was just writing exactly the same message 😀

So this must be to do with the different layout of node_modules used by pnpm.

It would be great if the default config supported pnpm (especially since the instructions say npm install (or pnpm install, etc). So I suppose the question is whether it is appropriate to fix (work around?) it in create-svelte as I have here, or whether it is something that should be fixed in Prettier.

I'd lean towards the former in the short term, but I guess it might be something to look at from Prettier's side too.

[Rich-Harris]

Ah, interesting. In that case the workaround probably makes sense, yeah