Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve promts, turn confirms into toggle #1312

Merged
merged 2 commits into from
May 3, 2021

Conversation

TheWolfNL
Copy link
Contributor

@TheWolfNL TheWolfNL commented May 3, 2021

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.

    This change will make it obvious what the default values are, and what the alternatives are.
    I found myself having to run the init multiple times since the default was not obvious or I 'entered' past it 😅
    The resulting values remain the same as before the change.
    Example of the changed promts
    Use arrow keys/tab/space to switch between options, enter to select.

  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test
  • Lint the project with pnpm lint

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpx changeset and following the prompts

@Rich-Harris Rich-Harris merged commit 3fb191c into sveltejs:master May 3, 2021
@Rich-Harris
Copy link
Member

thanks!

@TheWolfNL TheWolfNL deleted the tweak-prompts branch May 3, 2021 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants