chore: fix flaky test

[benmccann]

I think our tests have been flaky ever since #11311

It's an easy fix, but I didn't know this test was flaky because GitHub was burying the logs. Thankfully @eltigerchino realized there were other errors in the logs that I didn't see

page.click won't wait for the navigation to complete where as clicknav will

[changeset-bot]

⚠️ No Changeset found

Latest commit: 02d4a7e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[eltigerchino]

Thanks Ben! The download test I added a while back is pretty flaky too. I attempted to fix it by adding a "wait for download event" in https://github.com/sveltejs/kit/pull/9747/files#diff-a546a23d82431e7dd623e165253e7a65f2571999354acab18c6f5423b69b9389 but it seems like it's still flaky (just less?). Would it be worth separating the fix for that test into a separate PR?

[benmccann]

Yeah, it seems like that's the other big one. Too bad it's not as easy to fix as this one

[eltigerchino]

Another one seems to be test.js:545:2 › Load › Prerendered +server.js called from a non-prerendered handle hook works