Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix weird type error in create-svelte bin.js #12221

Merged
merged 1 commit into from
May 16, 2024

Conversation

eltigerchino
Copy link
Member

@eltigerchino eltigerchino commented May 16, 2024

Adding an argument to the function changes the expected type of options.value from void to string. However, since we don't use the argument, we just name it _ and we get the benefit of not needing ts-expect-error anymore


Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

Copy link

changeset-bot bot commented May 16, 2024

⚠️ No Changeset found

Latest commit: f30e81d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Member

@dummdidumm dummdidumm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice find!

@eltigerchino
Copy link
Member Author

eltigerchino commented May 16, 2024

Thanks! Do chores like this need a changeset?

@dummdidumm
Copy link
Member

No it's fine for this one, doesn't change anything user-observable.

@dummdidumm dummdidumm merged commit 2649fd6 into main May 16, 2024
13 checks passed
@dummdidumm dummdidumm deleted the eltigerchino-patch-1 branch May 16, 2024 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants